mayankshriv commented on a change in pull request #4535: Implement DISTINCT 
clause
URL: https://github.com/apache/incubator-pinot/pull/4535#discussion_r319190135
 
 

 ##########
 File path: 
pinot-core/src/main/java/org/apache/pinot/core/plan/TransformPlanNode.java
 ##########
 @@ -124,6 +143,14 @@ public TransformOperator run() {
     return new TransformOperator(_projectionPlanNode.run(), new 
ArrayList<>(_expressionTrees));
   }
 
+  FieldSpec.DataType[] getProjectedColumnTypes() {
 
 Review comment:
   These api's don't seem to belong in TransformPlanNode. One option is to get 
it from metadata in projection block, or get it from the index-segment 
(preferred).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to