jackjlli commented on a change in pull request #4583: Support default value for
Byte column
URL: https://github.com/apache/incubator-pinot/pull/4583#discussion_r320992567
##########
File path:
pinot-common/src/test/java/org/apache/pinot/common/data/FieldSpecTest.java
##########
@@ -117,6 +117,17 @@ public void testFieldSpec() {
Assert.assertEquals(fieldSpec1.toString(), fieldSpec2.toString());
Assert.assertEquals(fieldSpec1.hashCode(), fieldSpec2.hashCode());
Assert.assertEquals(fieldSpec1.getDefaultNullValue(), 1L);
+
+ // Metric field with default null value for byte column.
+ fieldSpec1 = new MetricFieldSpec();
+ fieldSpec1.setName("btyeMetric");
Review comment:
good catch 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
