jackjlli commented on a change in pull request #4583: Support default value for
Byte column
URL: https://github.com/apache/incubator-pinot/pull/4583#discussion_r321940046
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java
##########
@@ -303,6 +304,10 @@ protected void createColumnV1Indices(String column)
dictionaryElementSize =
StringUtil.encodeUtf8(stringDefaultValue).length;
sortedArray = new String[]{stringDefaultValue};
break;
+ case BYTES:
+ Preconditions.checkState(defaultValue instanceof byte[]);
+ sortedArray = new ByteArray[] {new ByteArray((byte[]) defaultValue)};
Review comment:
Actually the value is already of byte array type. We can document what/how
to put a default value for byte column.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
