jackjlli commented on a change in pull request #4583: Support default value for 
Byte column
URL: https://github.com/apache/incubator-pinot/pull/4583#discussion_r325371081
 
 

 ##########
 File path: 
pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/SegmentColumnarIndexCreator.java
 ##########
 @@ -574,8 +575,14 @@ public static void 
addColumnMetadataInfo(PropertiesConfiguration properties, Str
     if (defaultNullValue == null) {
 
 Review comment:
   Correct, we have default null value for all kinds of types in FieldSpec. 
   Removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to