Jackie-Jiang commented on a change in pull request #4577: Adding integration test for Hadoop pre-process job URL: https://github.com/apache/incubator-pinot/pull/4577#discussion_r321001381
########## File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/mappers/SegmentPreprocessingMapper.java ########## @@ -43,14 +44,17 @@ private Schema _outputKeySchema; private Schema _outputSchema; private boolean _enablePartitioning; - private String _sampleNormalizedTimeColumnValue = null; - private NormalizedDateSegmentNameGenerator _normalizedDateSegmentNameGenerator = null; private boolean _isAppend = false; + private String _tableName; Review comment: (nit) seems we don't need the table name ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
