Jackie-Jiang commented on a change in pull request #4577: Adding integration
test for Hadoop pre-process job
URL: https://github.com/apache/incubator-pinot/pull/4577#discussion_r321001516
##########
File path:
pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentPreprocessingJob.java
##########
@@ -148,11 +144,12 @@ public void run()
final List<Path> inputDataPaths = getDataFilePaths(_inputSegmentDir);
Preconditions.checkState(inputDataPaths.size() != 0, "No files in the
input directory.");
+ JobPreparationHelper.setDirPermission(_fileSystem, _preprocessedOutputDir,
_defaultPermissionsMask);
Review comment:
Does setting permission on non-existing file work? Or should you set the
permission after the dir is created?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
