Jackie-Jiang commented on a change in pull request #4577: Adding integration
test for Hadoop pre-process job
URL: https://github.com/apache/incubator-pinot/pull/4577#discussion_r320995148
##########
File path:
pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentPreprocessingJob.java
##########
@@ -411,7 +408,7 @@ private void setValidationConfigs(Job job, Path path)
throws IOException {
job.getConfiguration().set(InternalConfigConstants.SEGMENT_TIME_FORMAT,
_pinotTableSchema.getTimeFieldSpec().getOutgoingGranularitySpec().getTimeFormat());
job.getConfiguration().set(InternalConfigConstants.SEGMENT_PUSH_FREQUENCY,
validationConfig.getSegmentPushFrequency());
try (DataFileStream<GenericRecord> dataStreamReader =
getAvroReader(path)) {
- job.getConfiguration().set(InternalConfigConstants.TIME_COLUMN_VALUE,
(String) dataStreamReader.next().get(timeColumnName));
+ job.getConfiguration().set(InternalConfigConstants.TIME_COLUMN_VALUE,
Integer.toString((int) dataStreamReader.next().get(timeColumnName)));
Review comment:
Use `dataStreamReader.next().get(timeColumnName).toString()` in case time
column is not of type INT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
