akshayrai commented on a change in pull request #4599: [TE] Redesign to support
multiple Alert Content formatters
URL: https://github.com/apache/incubator-pinot/pull/4599#discussion_r322912489
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/notification/content/templates/HierarchicalAnomaliesContent.java
##########
@@ -201,4 +211,38 @@ private AnomalyReportEntity
putAnomaliesIntoRootOrLeaf(MergedAnomalyResultDTO an
}
return anomalyReport;
}
+
+ /**
+ * Retrieve the average wow baseline values
+ * @param anomaly an instance of MergedAnomalyResultDTO
+ * @param compareMode the way to compare, WoW, Wo2W, Wo3W, and Wo4W
+ * @param start the start time of the monitoring window in millis
+ * @param end the end time of the monitoring window in millis
+ * @return baseline values based on compareMode
+ * @throws Exception
+ */
+ private Double getAvgComparisonBaseline(MergedAnomalyResultDTO anomaly,
COMPARE_MODE compareMode,
+ long start, long end) throws Exception{
+ AnomalyFunctionFactory anomalyFunctionFactory = new
AnomalyFunctionFactory(thirdEyeAnomalyConfig.getFunctionConfigPath());
Review comment:
I want to refrain from making any functionality changes in this PR. Moreover
this unused template will require some separate refactoring to make it work
with the new pipeline. So I'd postpone that for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
