akshayrai commented on a change in pull request #4599: [TE] Redesign to support multiple Alert Content formatters URL: https://github.com/apache/incubator-pinot/pull/4599#discussion_r322912504
########## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/notification/content/NotificationContent.java ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.pinot.thirdeye.notification.content; + +import java.util.Collection; +import java.util.Map; +import java.util.Properties; +import org.apache.pinot.thirdeye.anomaly.ThirdEyeAnomalyConfiguration; +import org.apache.pinot.thirdeye.anomalydetection.context.AnomalyResult; +import org.apache.pinot.thirdeye.datalayer.dto.AlertConfigDTO; +import org.apache.pinot.thirdeye.notification.formatter.ADContentFormatterContext; + + +/** + * Defines the notification content interface. + */ +public interface NotificationContent { + + /** + * Initialize the content formatter + */ + void init(Properties properties, ThirdEyeAnomalyConfiguration configuration); + + /** + * Generate the template dictionary from the list of anomaly results to render in the template + */ + Map<String, Object> format(AlertConfigDTO alertConfigDTO, Long groupId, String groupName, Collection<AnomalyResult> anomalies, ADContentFormatterContext context); Review comment: Yes, we can remove alertConfigDTO and rely on the context. good idea. AlertConfigDTO is still used by the onboarding notification pipeline. I'd avoid refactoring it in the same PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
