akshayrai commented on a change in pull request #4599: [TE] Redesign to support multiple Alert Content formatters URL: https://github.com/apache/incubator-pinot/pull/4599#discussion_r322978657
########## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/alert/commons/AnomalyFeedConfig.java ########## @@ -19,7 +19,7 @@ package org.apache.pinot.thirdeye.alert.commons; -import org.apache.pinot.thirdeye.datalayer.util.StringUtils; +import org.apache.pinot.thirdeye.datalayer.util.ThirdEyeStringUtils; Review comment: There is a standard `StringUtils` utility class in apache commons which is widely used. Having two such utility classes requires us to distinguish between them by referring to their complete package name. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
