9aman commented on code in PR #15347:
URL: https://github.com/apache/pinot/pull/15347#discussion_r2008746390
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/IngestionConfigUtils.java:
##########
@@ -101,11 +101,38 @@ public static List<Map<String, String>>
getStreamConfigMaps(TableConfig tableCon
return streamConfigMaps;
}
if (tableConfig.getIndexingConfig() != null &&
tableConfig.getIndexingConfig().getStreamConfigs() != null) {
- return Arrays.asList(tableConfig.getIndexingConfig().getStreamConfigs());
+ return List.of(tableConfig.getIndexingConfig().getStreamConfigs());
Review Comment:
Unrelated to this PR: `getStreamConfigMaps()` seems to be performing
validations on the streaamConfigMaps in case of multi-stream ingestion.
This should not be done in a getter. The `validate` function in the
`TableConfigUtils` relies on this to perform these checks when the
`tableConfig` is added/ updated. Ideally, there should be a separate function
for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
