Jackie-Jiang commented on code in PR #15347:
URL: https://github.com/apache/pinot/pull/15347#discussion_r2010692538
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -456,10 +453,9 @@ private boolean addSegmentToCommittingSegmentsList(String
realtimeTableName, Str
Stat stat = new Stat();
ZNRecord znRecord = _propertyStore.get(committingSegmentsListPath, stat,
AccessOption.PERSISTENT);
int expectedVersion = stat.getVersion();
- LOGGER.info("Committing segments list size: {} before adding the segment:
{}", Optional.ofNullable(znRecord)
- .map(record -> record.getListField(COMMITTING_SEGMENTS))
- .map(List::size)
- .orElse(0), segmentName);
+ LOGGER.info("Committing segments list size: {} before adding the segment:
{}",
+ Optional.ofNullable(znRecord).map(record ->
record.getListField(COMMITTING_SEGMENTS)).map(List::size).orElse(0),
Review Comment:
Reverted
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -493,10 +489,9 @@ private boolean
removeSegmentFromCommittingSegmentsList(String realtimeTableName
Stat stat = new Stat();
ZNRecord znRecord = _propertyStore.get(committingSegmentsListPath, stat,
AccessOption.PERSISTENT);
- LOGGER.info("Committing segments list size: {} before removing the
segment: {}", Optional.ofNullable(znRecord)
- .map(record -> record.getListField(COMMITTING_SEGMENTS))
- .map(List::size)
- .orElse(0), segmentName);
+ LOGGER.info("Committing segments list size: {} before removing the
segment: {}",
+ Optional.ofNullable(znRecord).map(record ->
record.getListField(COMMITTING_SEGMENTS)).map(List::size).orElse(0),
Review Comment:
Reverted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
