9aman commented on code in PR #15347:
URL: https://github.com/apache/pinot/pull/15347#discussion_r2008747041
##########
pinot-common/src/main/java/org/apache/pinot/common/metadata/segment/SegmentZKMetadata.java:
##########
@@ -309,6 +309,7 @@ public void setSizeThresholdToFlushSegment(int
flushThresholdSize) {
setNonNegativeValue(Segment.Realtime.FLUSH_THRESHOLD_SIZE,
flushThresholdSize);
}
+ @Deprecated
Review Comment:
How would we handle tables that have low ingestion rate.
What would happen if the Kafka retention is low and we don't end up hitting
size or row based thresholds for the consuming segments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
