Jackie-Jiang commented on a change in pull request #4646: Enabling alternative
controller rest API classes in preprocess
URL: https://github.com/apache/incubator-pinot/pull/4646#discussion_r328850332
##########
File path:
pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentCreationJob.java
##########
@@ -194,35 +191,6 @@ public void run()
_fileSystem.delete(_stagingDir, true);
}
- @Nullable
- protected TableConfig getTableConfig()
- throws IOException {
- try (ControllerRestApi controllerRestApi = getControllerRestApi()) {
- return controllerRestApi != null ? controllerRestApi.getTableConfig() :
null;
- }
- }
-
- protected Schema getSchema()
- throws IOException {
- try (ControllerRestApi controllerRestApi = getControllerRestApi()) {
- if (controllerRestApi != null) {
- return controllerRestApi.getSchema();
- } else {
- try (InputStream inputStream = _fileSystem.open(_schemaFile)) {
Review comment:
Remove the `_schemaFile` member variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
