Jackie-Jiang commented on a change in pull request #4646: Enabling alternative controller rest API classes in preprocess URL: https://github.com/apache/incubator-pinot/pull/4646#discussion_r328888628
########## File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentPreprocessingJob.java ########## @@ -87,10 +88,11 @@ private final Path _inputSegmentDir; private final Path _preprocessedOutputDir; protected final String _rawTableName; - protected final List<PushLocation> _pushLocations; + protected List<PushLocation> _pushLocations; Review comment: Remove the member variables that are already in the base segment job (_pushLocations and _rawTableName). Same for SegmentCreationJob. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
