Jackie-Jiang commented on a change in pull request #4646: Enabling alternative
controller rest API classes in preprocess
URL: https://github.com/apache/incubator-pinot/pull/4646#discussion_r328888751
##########
File path:
pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/SegmentPreprocessingJob.java
##########
@@ -115,9 +119,7 @@ public SegmentPreprocessingJob(final Properties
properties) {
_pushLocations =
PushLocation.getPushLocations(StringUtils.split(pushHostsString,
','), Integer.parseInt(pushPortString));
} else {
- throw new RuntimeException(String
- .format("Push location is mis-configured! %s: %s, %s: %s",
JobConfigConstants.PUSH_TO_HOSTS, pushHostsString,
- JobConfigConstants.PUSH_TO_PORT, pushPortString));
+ _pushLocations = null;
Review comment:
Remove the code of setting _pushLocations and _rawTableName which are
already in the BaseSegmentJob. Same for SegmentCreationJob.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
