npawar commented on a change in pull request #4602: First pass of GROUP BY with
ORDER BY support
URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r332222014
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/table/IndexedTable.java
##########
@@ -32,38 +32,44 @@
* Base abstract implementation of Table for indexed lookup
*/
public abstract class IndexedTable implements Table {
- // When table reaches max capacity, we will allow 20% more records to get
inserted (bufferedCapacity)
- // If records beyond bufferedCapacity are received, the table will undergo
sort and evict upto evictCapacity (10% more than capacity)
- // This is to ensure that for a small number beyond capacity, a fair chance
is given to all records which have the potential to climb up the order
- /** Factor used to add buffer to maxCapacity of the Collection used **/
- private static final double BUFFER_FACTOR = 1.2;
- /** Factor used to decide eviction threshold **/
- private static final double EVICTION_FACTOR = 1.1;
List<AggregationFunction> _aggregationFunctions;
DataSchema _dataSchema;
- List<AggregationInfo> _aggregationInfos;
- List<SelectionSort> _orderBy;
+ boolean _sort;
int _maxCapacity;
- int _evictCapacity;
int _bufferedCapacity;
@Override
public void init(@Nonnull DataSchema dataSchema, List<AggregationInfo>
aggregationInfos, List<SelectionSort> orderBy,
- int maxCapacity) {
+ int maxCapacity, boolean sort) {
Review comment:
Refactored to pass sort flag in finish() instead of init()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
