npawar commented on a change in pull request #4602: First pass of GROUP BY with
ORDER BY support
URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r332223055
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/IntermediateResultsBlock.java
##########
@@ -45,7 +50,7 @@
* The <code>IntermediateResultsBlock</code> class is the holder of the server
side inter-segment results.
*/
public class IntermediateResultsBlock implements Block {
- private DataSchema _selectionDataSchema;
+ private DataSchema _dataSchema;
Review comment:
I prefer not to make the change about reordering columns in this iteration.
Can we take it up in following PRs? I've already noted it down in the list of
possible optimizations.
The data schema is mainly needed for the Table structure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
