9aman commented on code in PR #16572:
URL: https://github.com/apache/pinot/pull/16572#discussion_r2284269155
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeConsumptionRateManager.java:
##########
@@ -115,12 +124,22 @@ private void createOrUpdateServerRateLimiter(double
serverRateLimit, ServerMetri
// result of it, But the metric related to throttling won't be emitted
since as a result of here above the
Review Comment:
Curious about this comment here. What happens when the metric is closed and
throttle is called as it does
_metricEmitter.record(units); // just incrementing counter
(non-blocking)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
