9aman commented on code in PR #16572:
URL: https://github.com/apache/pinot/pull/16572#discussion_r2284313505
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeConsumptionRateManager.java:
##########
@@ -258,14 +307,15 @@ private PartitionRateLimiter(double rate, ServerMetrics
serverMetrics, String me
}
@Override
- public void throttle(int numMsgs) {
+ public void throttle(MessageBatch messageBatch) {
if (InstanceHolder.INSTANCE._isThrottlingAllowed) {
+ int units = messageBatch.getMessageCount();
Review Comment:
Is rate limiting at server level restricted to number of messages ?
Is there a requirement for having byte level rate limiting at table/
partition level ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
