gortiz commented on code in PR #16658:
URL: https://github.com/apache/pinot/pull/16658#discussion_r2291686643
##########
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java:
##########
@@ -246,7 +246,7 @@ public static FunctionInfo getFunctionInfo(String name, int
numArguments) {
}
public static String canonicalize(String name) {
- return StringUtils.remove(name, '_').toLowerCase();
+ return StringUtils.remove(StringUtils.remove(name, '_'), '
').toLowerCase();
Review Comment:
I can try to take a look tomorrow, but IIRC I tried that and it ended up
producing parsing issues. On the other hand, ni don't think the cost is too
heavy. In the worse case scenario I can rewrite this code to do the same in a
single copy and a single iteration over the name of the function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
