gortiz commented on code in PR #16658:
URL: https://github.com/apache/pinot/pull/16658#discussion_r2293701158
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/NullHandlingIntegrationTest.java:
##########
@@ -351,6 +359,42 @@ public void testWindowFunctionIgnoreNulls()
}
}
Review Comment:
Yes, with null handling that will be transformed into
`LogicalValues(tuples=[[]])`, which is equivalent to say that no row is
returned and without null handling it will just check both predicates (which
will probably be equivalent, but depends on the default null value and wether
the col is a metric or a dimension)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
