Jackie-Jiang commented on code in PR #16658:
URL: https://github.com/apache/pinot/pull/16658#discussion_r2291696511
##########
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java:
##########
@@ -246,7 +246,7 @@ public static FunctionInfo getFunctionInfo(String name, int
numArguments) {
}
public static String canonicalize(String name) {
- return StringUtils.remove(name, '_').toLowerCase();
+ return StringUtils.remove(StringUtils.remove(name, '_'), '
').toLowerCase();
Review Comment:
This is also causing inconsistency between `FunctionRegistry` and
`TransformFunctionFactory`. Ideally I want to keep them the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
