cypherean commented on code in PR #16583:
URL: https://github.com/apache/pinot/pull/16583#discussion_r2325746371
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/docidsets/OrDocIdSet.java:
##########
@@ -53,10 +54,16 @@ public final class OrDocIdSet implements BlockDocIdSet {
private final int _numDocs;
private List<BlockDocIdSet> _docIdSets;
private volatile long _numEntriesScannedInFilter = 0L;
+ private boolean _isAlwaysFalse;
Review Comment:
This approach was taken to preserve the numEntriesScanned accurately.
_isAlwaysFalse was added to avoid some unnecessary steps but alternatively we
can have a wrapper over EmptyDocIdSet that stores numEntriesScannedInFilter or
make the decision to not store it for early short circuit.
Should I go ahead with the EmptyDocIdSet wrapper approach then?
cc @ankitsultana
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
