ankitsultana commented on code in PR #16583:
URL: https://github.com/apache/pinot/pull/16583#discussion_r2357262410
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/docidsets/AndDocIdSet.java:
##########
@@ -165,6 +166,9 @@ public BlockDocIdIterator iterator() {
}
}
for (ScanBasedDocIdIterator scanBasedDocIdIterator :
scanBasedDocIdIterators) {
+ if (!docIds.cardinalityExceeds(0)) {
Review Comment:
nit: I think this has only marginal benefit and introduces a new control
flow. we can skip this imo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
