ankitsultana commented on code in PR #16583:
URL: https://github.com/apache/pinot/pull/16583#discussion_r2330884067
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/docidsets/OrDocIdSet.java:
##########
@@ -53,10 +54,16 @@ public final class OrDocIdSet implements BlockDocIdSet {
private final int _numDocs;
private List<BlockDocIdSet> _docIdSets;
private volatile long _numEntriesScannedInFilter = 0L;
+ private boolean _isAlwaysFalse;
Review Comment:
Yeah the `isAlwaysFalse` approach for And and Or doc id sets seems like a
code-smell.
We could create a new `ShortCircuitingDocIdSet` which calculates the entries
scanned in filter metrics correctly. (you can also refactor the existing
EmptyDocIdSet. that also lgtm)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
