suvodeep-pyne commented on code in PR #16823:
URL: https://github.com/apache/pinot/pull/16823#discussion_r2350316529
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -129,6 +131,12 @@ public abstract class BaseBrokerStarter implements
ServiceStartable {
private volatile boolean _isStarting = false;
private volatile boolean _isShuttingDown = false;
+ // Class dedicated towards handling cluster config change
+ protected final DefaultClusterConfigChangeHandler
_defaultClusterConfigChangeHandler =
+ new DefaultClusterConfigChangeHandler();
+
+ // Deprecated in favor of using a dedicated
_defaultClusterConfigChangeHandler to manage config related changes
+ @Deprecated
Review Comment:
Yes. This is being used by others currently. This is more like a signal.
Marking them `@Deprecated` is a way to ensure more folks don't follow the same
trend and provides clear direction on which one to use given both options.
```
protected final List<ClusterChangeHandler> _clusterConfigChangeHandlers =
new ArrayList<>();
protected final List<ClusterChangeHandler> _idealStateChangeHandlers = new
ArrayList<>();
protected final List<ClusterChangeHandler> _externalViewChangeHandlers =
new ArrayList<>();
protected final List<ClusterChangeHandler> _instanceConfigChangeHandlers =
new ArrayList<>();
protected final List<ClusterChangeHandler> _liveInstanceChangeHandlers =
new ArrayList<>();
```
The current design uses 5 different `ClusterChangeHandler` lists to manage
different kinds of use.
I think being decisive at this time helps make the decision for others going
forward as we plan to refactor integrate all cluster config handling to a
central class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
