somandal commented on code in PR #16823:
URL: https://github.com/apache/pinot/pull/16823#discussion_r2352837629
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -129,6 +131,12 @@ public abstract class BaseBrokerStarter implements
ServiceStartable {
private volatile boolean _isStarting = false;
private volatile boolean _isShuttingDown = false;
+ // Class dedicated towards handling cluster config change
+ protected final DefaultClusterConfigChangeHandler
_defaultClusterConfigChangeHandler =
+ new DefaultClusterConfigChangeHandler();
+
+ // Deprecated in favor of using a dedicated
_defaultClusterConfigChangeHandler to manage config related changes
+ @Deprecated
Review Comment:
I don't think deprecating the existing ClusterChangeHandler is the right
long-term approach. I would prefer if we consolidated everything going forward
instead. The existing ClusterChangeMediator / ClusterChangeHandler do many
other things like periodically syncing the configs in case Helix callback is
missed, etc, which could be useful to have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
