9aman commented on code in PR #16856:
URL: https://github.com/apache/pinot/pull/16856#discussion_r2377794790
##########
pinot-controller/src/main/java/org/apache/pinot/controller/validation/OfflineSegmentValidationManager.java:
##########
@@ -47,20 +48,22 @@
* Manages the segment validation metrics, to ensure that all offline segments
are contiguous (no missing segments) and
* that the offline push delay isn't too high.
*/
-public class OfflineSegmentIntervalChecker extends
ControllerPeriodicTask<Void> {
- private static final Logger LOGGER =
LoggerFactory.getLogger(OfflineSegmentIntervalChecker.class);
+public class OfflineSegmentValidationManager extends
ControllerPeriodicTask<Void> {
Review Comment:
The reason for renaming is 2 way:
1. It's no more an `OfflineSegmentIntervalChecker`
2. Have a periodic job, for OFFLINE tables, similar to that of
RealtimeSegmentValidationManager
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
