Jackie-Jiang commented on code in PR #16856:
URL: https://github.com/apache/pinot/pull/16856#discussion_r2383274184
##########
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##########
@@ -240,6 +240,10 @@ public static class ControllerPeriodicTasksConf {
"controller.retentionManager.initialDelayInSeconds";
public static final String
OFFLINE_SEGMENT_INTERVAL_CHECKER_INITIAL_DELAY_IN_SECONDS =
"controller.offlineSegmentIntervalChecker.initialDelayInSeconds";
Review Comment:
Take a look at
`ControllerConf.getRealtimeSegmentValidationFrequencyInSeconds()` as an example
of how to handle deprecated old config key.
Since we are renaming an existing periodic task to a new name, we should
make sure:
1. The old config can still be honored, but mark it as deprecated
2. Introduce new config to comply with the new name
3. Change documentation to reference the new name
4. Controller should be able to understand the old periodic task name when
user triggers periodic task with the old name
Actually there is another example, where `RealtimeSegmentRelocator` was
renamed as `SegmentRelocator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
