somandal commented on code in PR #16856:
URL: https://github.com/apache/pinot/pull/16856#discussion_r2379780418


##########
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##########
@@ -240,6 +240,10 @@ public static class ControllerPeriodicTasksConf {
         "controller.retentionManager.initialDelayInSeconds";
     public static final String 
OFFLINE_SEGMENT_INTERVAL_CHECKER_INITIAL_DELAY_IN_SECONDS =
         "controller.offlineSegmentIntervalChecker.initialDelayInSeconds";

Review Comment:
   yeah this is what I meant, now there's a mismatch of the periodic task name 
and can become difficult to maintain in the future due to the rename. can cause 
user error



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to