Jackie-Jiang commented on a change in pull request #4585: Presence vector
URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r338320678
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -379,6 +393,25 @@ private void addInvertedIndex(int docId, Map<String,
Object> dictIdMap) {
}
}
+ /**
+ * Check if the row has any null fields and update the
+ * column presence vectors accordingly
+ * @param row specifies row being ingested
+ * @param docId specified docId for this row
+ */
+ private void addPresenceVector(GenericRow row, int docId) {
+ if (!row.hasNullValues()) {
+ return;
+ }
+
+ for (FieldSpec fieldSpec : _schema.getAllFieldSpecs()) {
Review comment:
Iterate over `row.getNullValueFields()` and set presence vector
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
