Jackie-Jiang commented on a change in pull request #4585: Presence vector
URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r338319772
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/data/GenericRow.java
##########
@@ -90,6 +90,11 @@ public boolean isNullValue(String fieldName) {
return _nullValueFields.contains(fieldName);
}
+ /**
+ * Returns whether this row has null values for any of the columns
+ */
+ public boolean hasNullValues() { return _nullValueFields.size() > 0; }
Review comment:
(Code style) Expand this into 3 lines.
(nit) `return !_nullValueFields.isEmpty()` seems more readable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
