xiangfu0 commented on code in PR #18165:
URL: https://github.com/apache/pinot/pull/18165#discussion_r3072608886
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/function/FunctionEvaluator.java:
##########
@@ -18,27 +18,10 @@
*/
package org.apache.pinot.segment.local.function;
-import java.util.List;
-import org.apache.pinot.spi.data.readers.GenericRow;
-
-
/**
- * Interface for evaluators of transform function expressions of schema field
specs
+ * @deprecated Use {@link
org.apache.pinot.segment.spi.function.FunctionEvaluator}. This bridge remains
so existing
+ * segment-local callers continue to compile while the interface
lives in {@code pinot-segment-spi}.
*/
-public interface FunctionEvaluator {
-
- /**
- * Get the arguments of the function
- */
- List<String> getArguments();
-
- /**
- * Evaluate the function on the generic row and return the result
- */
- Object evaluate(GenericRow genericRow);
-
- /**
- * Evaluates the function on the given values (same order as the arguments)
and returns the result.
- */
- Object evaluate(Object[] values);
+@Deprecated
+public interface FunctionEvaluator extends
org.apache.pinot.segment.spi.function.FunctionEvaluator {
Review Comment:
delete this and refactor to use pinot-segment-spi module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
