xiangfu0 commented on code in PR #18165: URL: https://github.com/apache/pinot/pull/18165#discussion_r3070844691
########## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/partition/pipeline/PartitionFunctionExprCompiler.java: ########## @@ -0,0 +1,1206 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.spi.partition.pipeline; + +import com.google.common.base.Preconditions; +import java.lang.reflect.Array; +import java.lang.reflect.Constructor; +import java.lang.reflect.InvocationTargetException; +import java.lang.reflect.Method; +import java.lang.reflect.Modifier; +import java.util.ArrayList; +import java.util.Collections; +import java.util.EnumSet; +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Locale; +import java.util.Map; +import java.util.Set; +import javax.annotation.Nullable; +import org.apache.pinot.spi.annotations.ScalarFunction; +import org.apache.pinot.spi.config.table.ColumnPartitionConfig; +import org.apache.pinot.spi.utils.ScalarFunctionUtils; + +import static java.nio.charset.StandardCharsets.UTF_8; + + +/** + * Compiles a restricted partition-function expression into a typed {@link PartitionPipeline} backed by deterministic + * scalar functions. + */ +public final class PartitionFunctionExprCompiler { Review Comment: I kept the partition-expression planner separate on purpose, but it now reuses the shared execution layer rather than maintaining a second evaluator runtime. `PartitionFunctionExprCompiler` builds the same `ExecutableFunctionEvaluator` node tree used by `InbuiltFunctionEvaluator`, and scalar lookup/invocation is consolidated through `FunctionRegistry`/`FunctionInvoker` in `CommonPartitionScalarFunctionResolver`. I did not switch partition expressions over to `InbuiltFunctionEvaluator` directly because its contract is broader than the partition DSL: it parses the full transform-expression grammar, supports multi-column expressions/boolean nodes, and sits behind `FunctionEvaluatorFactory`, which is also where Groovy is allowed. For partitioning we still need the restricted single-column + literal chain, compile-time type validation (including BYTES intermediates), and deterministic-function gating. Reusing `InbuiltFunctionEvaluator` directly would either widen the surface area beyond the PR scope or reintroduce the same validation layer on top of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
