xiangfu0 commented on code in PR #18165:
URL: https://github.com/apache/pinot/pull/18165#discussion_r3068931767
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/partition/metadata/ColumnPartitionMetadata.java:
##########
@@ -60,14 +63,36 @@ public class ColumnPartitionMetadata {
* @param partitions Set of partitions the column contains
* @param functionConfig Configuration required by partition function.
*/
+ @Deprecated
public ColumnPartitionMetadata(String functionName, int numPartitions,
Set<Integer> partitions,
@Nullable Map<String, String> functionConfig) {
+ this(functionName, numPartitions, partitions, functionConfig, null, null);
+ }
+
+ @Deprecated
+ public ColumnPartitionMetadata(String functionName, int numPartitions,
Set<Integer> partitions,
Review Comment:
remove this
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/partition/metadata/ColumnPartitionMetadata.java:
##########
@@ -60,14 +63,36 @@ public class ColumnPartitionMetadata {
* @param partitions Set of partitions the column contains
* @param functionConfig Configuration required by partition function.
*/
+ @Deprecated
public ColumnPartitionMetadata(String functionName, int numPartitions,
Set<Integer> partitions,
@Nullable Map<String, String> functionConfig) {
+ this(functionName, numPartitions, partitions, functionConfig, null, null);
+ }
+
+ @Deprecated
+ public ColumnPartitionMetadata(String functionName, int numPartitions,
Set<Integer> partitions,
+ @Nullable Map<String, String> functionConfig, @Nullable String
functionExpr) {
+ this(functionName, numPartitions, partitions, functionConfig,
functionExpr, null);
+ }
+
+ @Deprecated
+ public ColumnPartitionMetadata(String functionName, int numPartitions,
Set<Integer> partitions,
Review Comment:
remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
