siddharthteotia commented on a change in pull request #4790: Support ORDER BY
for DISTINCT queries
URL: https://github.com/apache/incubator-pinot/pull/4790#discussion_r342434133
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java
##########
@@ -378,69 +378,43 @@ private boolean isDistinct(final AggregationFunction[]
aggregationFunctions) {
* @param dataSchema data schema.
*/
@SuppressWarnings("unchecked")
- private void setAggregationResults(BrokerResponseNative brokerResponseNative,
+ private void setAggregationResults(BrokerRequest brokerRequest,
BrokerResponseNative brokerResponseNative,
Review comment:
bad github review -- I have only moved the if condition to beginning of the
function and rest everything is unchanged. It shows as if the function has been
rewritten
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
