siddharthteotia commented on a change in pull request #4790: Support ORDER BY
for DISTINCT queries
URL: https://github.com/apache/incubator-pinot/pull/4790#discussion_r342853088
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/table/SimpleIndexedTable.java
##########
@@ -139,6 +144,14 @@ public int size() {
@Override
public Iterator<Record> iterator() {
+ if (_iterator == null) {
Review comment:
Yes we can either augment finish() by passing additional argument to tell it
not do anything except create an iterator or for now we can call finish() first
before the server combine and evaluate later. I am more inclined towards
changing the API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
