siddharthteotia commented on a change in pull request #4790: Support ORDER BY
for DISTINCT queries
URL: https://github.com/apache/incubator-pinot/pull/4790#discussion_r342691945
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -481,10 +481,6 @@ static void validateRequest(BrokerRequest brokerRequest,
int queryResponseLimit)
// TODO: Explore if DISTINCT should be supported with GROUP BY
throw new UnsupportedOperationException("DISTINCT with GROUP BY is
currently not supported");
}
- if (brokerRequest.isSetOrderBy()) {
Review comment:
Good point. This query should result in compile time error. Let me add tests
for these.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
