mayankshriv commented on a change in pull request #4790: Support ORDER BY for
DISTINCT queries
URL: https://github.com/apache/incubator-pinot/pull/4790#discussion_r342569675
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/table/SimpleIndexedTable.java
##########
@@ -139,6 +144,14 @@ public int size() {
@Override
public Iterator<Record> iterator() {
+ if (_iterator == null) {
Review comment:
Curious, as to why would we not always create new iterator here? Otherwise,
once the iterator has been iterated upon, other callers won't be able to
iterate again on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
