mayankshriv commented on a change in pull request #4790: Support ORDER BY for
DISTINCT queries
URL: https://github.com/apache/incubator-pinot/pull/4790#discussion_r342567614
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/table/IndexedTable.java
##########
@@ -76,6 +83,10 @@ public IndexedTable(DataSchema dataSchema,
List<AggregationInfo> aggregationInfo
_capacity = capacity;
}
+ protected void createResizer(int capacity, List<AggregationInfo>
aggregationInfos, List<SelectionSort> orderBy) {
Review comment:
This is somewhat confusing to read:
1. The method name is called createResizer, but it returns a void.
2. All it does is, is call another method named `setCapacityAndMaxCapacity`,
i.e. confusing on where the resizer is being created.
You might just move the resizer creation inside of the constructor, or
rename the methods to be more readable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
