mayankshriv commented on a change in pull request #4790: Support ORDER BY for
DISTINCT queries
URL: https://github.com/apache/incubator-pinot/pull/4790#discussion_r342564089
##########
File path:
pinot-broker/src/test/java/org/apache/pinot/broker/requesthandler/QueryValidationTest.java
##########
@@ -30,10 +30,7 @@
public void testUnsupportedDistinctQueries() {
Pql2Compiler compiler = new Pql2Compiler();
- String pql = "SELECT DISTINCT(col1, col2) FROM foo ORDER BY col1, col2";
Review comment:
If there's indeed a syntactically correct but semantically unsupported query
based on the comment above, then let's also add a test for that case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
