mcvsubbu commented on a change in pull request #4791: Support STRING and BYTES
for no dictionary columns in realtime consuming segments
URL: https://github.com/apache/incubator-pinot/pull/4791#discussion_r343796863
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/realtime/converter/stats/RealtimeNoDictionaryColStatistics.java
##########
@@ -63,12 +68,52 @@ public int getCardinality() {
@Override
public int getLengthOfShortestElement() {
- return lengthOfDataType(); // Only fixed length data types supported.
+ FieldSpec.DataType dataType = _blockValSet.getValueType();
+ if (dataType == FieldSpec.DataType.STRING || dataType ==
FieldSpec.DataType.BYTES) {
Review comment:
Let us introduce a method in FieldType isFixedWidth()? Will be easier when
/if we add new data types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
