mcvsubbu commented on a change in pull request #4791: Support STRING and BYTES
for no dictionary columns in realtime consuming segments
URL: https://github.com/apache/incubator-pinot/pull/4791#discussion_r365463777
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/DataSource.java
##########
@@ -52,4 +53,9 @@
*/
public abstract NullValueVectorReader getNullValueVector();
+ /**
+ * Returns the forward index for the data source
+ */
+ public abstract DataFileReader getForwardIndex();
Review comment:
Instead of modifying the DataSource interface and returning null in many
places, let us modify the ColumnDataSource class to get the forwrardIndex. We
can then use and type-cast it to our hearts content in the
RealtimeNoDictionaryColStatistics class. Since this class is very specific, the
type-casting should work fine without danger of exception
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
