mcvsubbu commented on a change in pull request #4791: Support STRING and BYTES for no dictionary columns in realtime consuming segments URL: https://github.com/apache/incubator-pinot/pull/4791#discussion_r365467434
########## File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java ########## @@ -76,6 +77,9 @@ private static final int MIN_ROWS_TO_INDEX = 1000_000; // Min size of recordIdMap for updatable metrics. private static final int MIN_RECORD_ID_MAP_CACHE_SIZE = 10000; // Min overflow map size for updatable metrics. + private static final int NODICT_VARIABLE_WIDTH_ESTIMATED_AVERAGE_VALUE_LENGTH = 100; Review comment: Maybe post-fix these definitions with DEFAULT at the end (since we will eventually get these from the stats) -- unless you are going to file the stats PR real soon. In that case, just let it be. this definition will probably move into the stats object ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
