tarun11Mavani commented on code in PR #18368:
URL: https://github.com/apache/pinot/pull/18368#discussion_r3252490327
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/ComplexFieldSpec.java:
##########
@@ -58,17 +60,29 @@ public final class ComplexFieldSpec extends FieldSpec {
private final Map<String, FieldSpec> _childFieldSpecs;
+ @JsonProperty("keyTypes")
+ private Map<String, DataType> _keyTypes;
Review Comment:
> These are value types right? How do you plan to use this config? Ideally
the value types should be auto detected
Renamed keyTypes → valueFieldSpecs: Map<String, FieldSpec> and
defaultValueType → defaultValueFieldSpec: FieldSpec.
Using FieldSpec instead of DataType gives us SV/MV via isSingleValueField(),
fieldType discrimination (DIMENSION vs METRIC for correct null semantics), and
consistency with _childFieldSpecs which already uses Map<String, FieldSpec>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
