tarun11Mavani commented on code in PR #18368:
URL: https://github.com/apache/pinot/pull/18368#discussion_r3260623511
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/FieldConfig.java:
##########
@@ -71,6 +71,24 @@ public class FieldConfig extends BaseJsonConfig {
public static final String
TEXT_INDEX_LUCENE_NRT_CACHING_DIRECTORY_BUFFER_SIZE =
"luceneNRTCachingDirectoryMaxBufferSizeMB";
+ /// MAP index property keys, passed via `FieldConfig.properties`.
+ /// See `MapIndexConfig` for semantics.
+
+ /// Maximum number of MAP keys to materialise as dense columns (default
1000).
+ public static final String MAP_INDEX_MAX_DENSE_KEYS = "maxDenseKeys";
Review Comment:
When more than max dense keys qualify, we sort them based on fill rate and
keep top max.
I feel it's a good guardrail to have to avoid blowing up segment with too
many keys. If you feel 1k is too low, I can increase the default to even higher
number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
