tarun11Mavani commented on PR #18368:
URL: https://github.com/apache/pinot/pull/18368#issuecomment-4479933295
> We need to discuss the index management for materialized key columns.
Currently it is modeled as a flat list per index type, which is hard to extend.
Can we put nested `List<FieldConfig>` under the `MapConfig` for the per key
config?
I do want to keep this as extendible as possible by allowing wiring more
indexes in future. Keeping it as a `FieldConfig` instead of `Set<String>` makes
sense.
I have updated the `MapIndexConfig` to have `List<FieldConfig>`. Here is a
sample config. This is much easier to extend for more index types.
```
{
"fieldConfigList": [{
"name": "metrics",
"indexes": {
"map": {
"maxDenseKeys": 1000,
"denseKeyMinFillRate": 0.5,
"denseKeys": ["country", "clicks"],
"enableInvertedIndexForDense": false,
"valueFieldConfigs": [
{"name": "country", "encodingType": "DICTIONARY", "indexes":
{"inverted": {}}},
{"name": "clicks", "encodingType": "RAW"}
]
}
}
}]
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
