xiangfu0 commented on PR #18687: URL: https://github.com/apache/pinot/pull/18687#issuecomment-4628035039
Follow-up status: 1. Test hygiene: addressed in `a7ea04e720` by wrapping the new `KafkaStreamMetadataProvider` instances in `KafkaPartitionLevelConsumerTest` with try-with-resources for both Kafka 3.0 and 4.0. 2. Per-partition fetch fan-out: intentionally left as a later optimization because this PR preserves the previous SPI-default cost model and keeps the bug fix scoped. 3. Vanished-partition parity: intentionally left unchanged; Kafka partitions normally do not shrink, and treating a partition absent from live Kafka metadata as unavailable/end-of-life is acceptable for this scoped recovery fix. All review threads are resolved/outdated after the latest push. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
