Jackie-Jiang commented on code in PR #18687:
URL: https://github.com/apache/pinot/pull/18687#discussion_r3375905862
##########
pinot-plugins/pinot-stream-ingestion/pinot-kafka-3.0/src/main/java/org/apache/pinot/plugin/stream/kafka30/KafkaStreamMetadataProvider.java:
##########
@@ -124,8 +124,31 @@ public List<PartitionGroupMetadata>
computePartitionGroupMetadata(String clientI
List<PartitionGroupConsumptionStatus> partitionGroupConsumptionStatuses,
int timeoutMillis)
throws IOException, java.util.concurrent.TimeoutException {
if (_partitionIdSubset.isEmpty()) {
- return
StreamMetadataProvider.super.computePartitionGroupMetadata(clientId,
streamConfig,
Review Comment:
We should fix this method instead. Ideally, we should also pass
`_partitionIdSubset` into the method. No reason to duplicate the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
